Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dev-tool: generated wrong market type #5254

Merged
merged 1 commit into from
Sep 1, 2022
Merged

fix: dev-tool: generated wrong market type #5254

merged 1 commit into from
Sep 1, 2022
+2 −1

Conversation

zl03jsj
Copy link
Contributor

@zl03jsj zl03jsj commented Sep 1, 2022

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

fix: dev-tool: generated wrong market type

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前，需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

hunjixin
hunjixin approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@hunjixin hunjixin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

simlecode
simlecode approved these changes Sep 1, 2022
View reviewed changes
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #5254 (ddefc28) into master (693bcaa) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5254   +/-   ##
======================================
  Coverage      25%     25%           
======================================
  Files         588     588           
  Lines       65028   65028           
======================================
+ Hits        16350   16353    +3     
+ Misses      46529   46525    -4     
- Partials     2149    2150    +1

@zl03jsj zl03jsj merged commit 8410841 into master Sep 1, 2022
@zl03jsj zl03jsj deleted the fix/generated-worry-type branch September 1, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simlecode simlecode simlecode approved these changes

@hunjixin hunjixin hunjixin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zl03jsj @codecov-commenter @hunjixin @simlecode